Log Updates #4024
Merged
Log Updates #4024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realforest2001
added
the
Testmerge Candidate
3 tasks
harryob
requested changes
Jul 29, 2023
|
Okay, but what do Xenos get? |
3 tasks
3 tasks
3 tasks
This was referenced Aug 2, 2023
3 tasks
3 tasks
harryob
approved these changes
Aug 3, 2023
cm13-github
added a commit
that referenced
this pull request
Aug 3, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 11, 2023
# About the pull request Merges the AntiAir and Security Update logs. Fixes Security Updates to actually work (I still don't know why they weren't working) Replaces AntiAir logs with the flight records from logs I made in #4024 Fixes ARES logs keeping the mob datum rather than just passing the name string. <!-- Remove this text and explain what the purpose of your PR is. Mention if you have tested your changes. If you changed a map, make sure you used the mapmerge tool. If this is an Issue Correction, you can type "Fixes Issue #169420" to link the PR to the corresponding Issue number #169420. Remember: something that is self-evident to you might not be to others. Explain your rationale fully, even if you feel it goes without saying. --> # Explain why it's good for the game # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> Put screenshots and videos here with an empty line between the screenshots and the `<details>` tags. </details> # Changelog :cl: fix: Fixes ARES Security Logs and stops ARES logs recording mob datums instead of names. add: Moves AntiAir records to Security Logs. add: Adds Flight Records to ARES Interface, detailing launches and setting changes. Does not include CAS details. code: Changes ARES log procs from using 'user' to 'user_name' to identify it should be the string rather than mob datum. /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Adds new and updates old logs.
Explain why it's good for the game
Knowledge is power.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
admin: Added logs for speech through telephones and deferring ahelps to mentors.
admin: Chestburst logs now include location data. Mentor Imaginary Friend now logs its speech. Narrow miss shots now log who fired them (where applicable).
admin: Dropship interactions (Launch/Flyby/Autopilot) are now logged again, and also included in attack logs for the user.
/:cl: