Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnested Larva Maturation Prompts #4041

Merged
merged 3 commits into from
Jul 30, 2023

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented Jul 29, 2023

About the pull request

This PR adds 10s tgui_alerts asking an observer to take over a maturing larva (an embryo that reached stage 5 in a host) if the host is unnested. They will automatically orbit the bursting mob when prompted. It will make 5 attempts at this. If the host is nested, the process will proceed as it has without any prompts.

This PR also fixes the pool flash not occurring for bursts from hosts.

Explain why it's good for the game

For the pool flash, that should have just been occurring in the first place.

For the prompts:

  • This allows observers to opt out of accepting a larva spawn in what they deem an impossible scenario - or at least a scenario they don't want to risk their place in queue for.
  • This now makes up to 5 attempts from the queue (technically 6 if you count a player hugger 2nd dibs) to put a player into a bursting larva rather than a single attempt. A side effect to this though is it can potentially increase the time to autoburst up to one minute while we're querying candidates.
  • This ensures that the new larva has an active player that didn't step away a moment ago (the queue allows a 5 minute window for inactivity)

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 Drathek
add: Added prompts for xeno candidates to optionally take over a larva when an unnested host is ready to burst
fix: Fixed larva spawning in hosts not triggering the preference unpool taskbar flash.
/:cl:

@github-actions github-actions bot added Feature Feature coder badge Fix Fix one bug, make ten more labels Jul 29, 2023
@cm13live
Copy link

This pull request has been mentioned on CM-SS13. Please provide feedback here:

https://forum.cm-ss13.com/t/rework-larva-queue/3050/73

@harryob harryob added this pull request to the merge queue Jul 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 30, 2023
@harryob harryob added this pull request to the merge queue Jul 30, 2023
Merged via the queue into cmss13-devs:master with commit a349d55 Jul 30, 2023
27 checks passed
cm13-github added a commit that referenced this pull request Jul 30, 2023
@Drulikar Drulikar deleted the Unnested_Prompts branch July 31, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants