Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yautja Weapon Gimmicks #4047

Closed

Conversation

realforest2001
Copy link
Member

@realforest2001 realforest2001 commented Jul 29, 2023

About the pull request

Work on giving Yautja Weapons gimmicks again.

Explain why it's good for the game

Work in Progress. Allows Yautja weapons to have some flair beyond being variably effective sticks.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Yautja weapons now collect blood 'charges' for using their abilites.
add: Combistick now requires two hits to throw instead of one, but can store up to two throws.
add: Scythe now can perform an AOE attack similar to Ravager Eviscerate, after five successful hits.
balance: Reduced the probability for combistick blocking from 2/3 hits to 1/3
balance: Added a 33% chance that instead of knocking yautja mask off, it degrades the hug resistance. Also repaired the 15% hardcap on knock chance.
/:cl:

@realforest2001 realforest2001 added this to the Yautja Rework milestone Jul 29, 2023
@github-actions github-actions bot added the Feature Feature coder badge label Jul 29, 2023
@realforest2001 realforest2001 added the Do Not Merge If you merge this PR, I will annihilate you label Aug 1, 2023
@realforest2001
Copy link
Member Author

Pending review/discussion on the gimmick of bleeding as it doesn't really have much of an effect beyond the natural bleed

@realforest2001 realforest2001 changed the title Yautja Scythe Bleed effect Yautja Weapon Gimmicks Aug 2, 2023
Zonespace27

This comment was marked as outdated.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Aug 8, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Aug 8, 2023
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Aug 9, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Aug 10, 2023
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Aug 18, 2023
@realforest2001 realforest2001 removed Do Not Merge If you merge this PR, I will annihilate you Stale beg a maintainer to review your PR labels Aug 19, 2023
code/modules/cm_preds/yaut_weapons.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft September 11, 2023 06:01
@realforest2001 realforest2001 marked this pull request as ready for review September 11, 2023 23:36
@realforest2001 realforest2001 marked this pull request as draft September 13, 2023 20:31
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Sep 28, 2023
@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Sep 30, 2023
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Oct 19, 2023
@github-actions github-actions bot closed this Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants