Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remove iv needing power to operate. #4070

Merged
merged 9 commits into from
Aug 9, 2023

Conversation

Huffie56
Copy link
Contributor

@Huffie56 Huffie56 commented Jul 31, 2023

About the pull request

fixes: #3848
and add a skill check like for the blood pack.
also turned four variable with a single letter into better ones.

Explain why it's good for the game

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Add a skill check to operate IV.
fix: Fix remove iv needing power to operate.
/:cl:

@github-actions github-actions bot added Feature Feature coder badge Fix Fix one bug, make ten more labels Jul 31, 2023
@Huffie56
Copy link
Contributor Author

the var to make a check skill can't be use there so i am just going to remove the skill check.....

sadly and i don't know how to fix....
@Drulikar
Copy link
Contributor

Drulikar commented Aug 1, 2023

the var to make a check skill can't be use there so i am just going to remove the skill check.....

That's because the variables have terrible names in this proc. You likely need usr not user.

@Huffie56
Copy link
Contributor Author

Huffie56 commented Aug 1, 2023

the var to make a check skill can't be use there so i am just going to remove the skill check.....

That's because the variables have terrible names in this proc. You likely need usr not user.

image

it's not user causing issue it seem it's the skill check... will keep looking into it....

code/game/machinery/iv_drip.dm Outdated Show resolved Hide resolved
code/game/machinery/iv_drip.dm Outdated Show resolved Hide resolved
code/game/machinery/iv_drip.dm Outdated Show resolved Hide resolved
code/game/machinery/iv_drip.dm Show resolved Hide resolved
@Drulikar
Copy link
Contributor

Drulikar commented Aug 1, 2023

i have no idea on how to fix the check skill issue so i will focus on making IV work without power for now...

As I mentioned, and as you can see from Forest's suggestions, you can't merely copy and paste code and expect every variable to be named the same thing. In your image, each error is because user does not exist for the same thing it did from where you copied this code.

image

@Huffie56 Huffie56 marked this pull request as ready for review August 2, 2023 12:00
code/game/machinery/iv_drip.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar marked this pull request as draft August 9, 2023 05:26
@Drulikar Drulikar marked this pull request as ready for review August 9, 2023 05:58
@Drulikar Drulikar added this pull request to the merge queue Aug 9, 2023
Merged via the queue into cmss13-devs:master with commit d93e8da Aug 9, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Aug 9, 2023
@Huffie56 Huffie56 deleted the fix_remove_iv_needing_power branch August 15, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IV Drips need to be powered
3 participants