Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo mistake from matchs to matches. #4073

Merged
merged 5 commits into from
Aug 12, 2023

Conversation

Huffie56
Copy link
Contributor

@Huffie56 Huffie56 commented Aug 1, 2023

About the pull request

fixes: #3795

Explain why it's good for the game

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
spellcheck: fix typo mistake from matchs to matches.
/:cl:

@github-actions github-actions bot added the Grammar and Formatting Fixes the codebase's tpyos and grammatical's errors label Aug 1, 2023
@Huffie56 Huffie56 marked this pull request as ready for review August 1, 2023 14:57
Copy link
Contributor

@Zonespace27 Zonespace27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use length(), not .len

@Zonespace27 Zonespace27 marked this pull request as draft August 3, 2023 16:34
@Huffie56
Copy link
Contributor Author

Huffie56 commented Aug 3, 2023

use length(), not .len

image
not working.

image

@Zonespace27
Copy link
Contributor

@Huffie56
Copy link
Contributor Author

Huffie56 commented Aug 3, 2023

https://www.byond.com/docs/ref/#/proc/length

image
this seem to work. atleast it don't crash...
this work but i have two examine text instead of one.......

code/game/objects/items/storage/fancy.dm Outdated Show resolved Hide resolved
code/game/objects/items/storage/fancy.dm Outdated Show resolved Hide resolved
@Huffie56
Copy link
Contributor Author

Huffie56 commented Aug 4, 2023

this work.
image

@Huffie56 Huffie56 marked this pull request as ready for review August 4, 2023 14:15
@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Aug 12, 2023
Copy link
Contributor

@Zonespace27 Zonespace27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Zonespace27 Zonespace27 added this pull request to the merge queue Aug 12, 2023
Merged via the queue into cmss13-devs:master with commit 6a4c62e Aug 12, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Aug 12, 2023
@Huffie56 Huffie56 deleted the fix-typo-matchs_matches branch August 15, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Grammar and Formatting Fixes the codebase's tpyos and grammatical's errors Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in Koorlander Matchbooks
2 participants