Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwatch Console TGUI Refactor #4078

Closed
wants to merge 16 commits into from

Conversation

TheGamerdk
Copy link
Contributor

@TheGamerdk TheGamerdk commented Aug 1, 2023

About the pull request

This redoes the whole console in TGUI.

Adds 2 new features:

Saving coordinates. You can now save up to 3 sets of coordinates, and attach comments. For easy dialling of supply drops and OBs
Multicam, observe up to 4 marines using the console. The window is smaller, and so is the detail.
This means you can overwatch up to 5 people (1 fullscreen, 4 multicam)

TODO:

  • Investigate multicam shit
  • Sort by role

Explain why it's good for the game

HTML ugly. TGUI Pretty.
Also gives a few neat CIC buffs

See screenshots below.

Testing Photographs and Procedure

Screenshots & Videos

image
image
image
image
image
image

Changelog

🆑
refactor: Refactors the overwatch console in TGUI
/:cl:

@github-actions github-actions bot added UI deletes nanoui/html Refactor Make the code harder to read labels Aug 1, 2023
@TheGamerdk
Copy link
Contributor Author

I don't know how to see the linter errors :(

@TheGamerdk
Copy link
Contributor Author

I don't know how to see the linter errors :(

i figured it out :)

code/modules/cm_marines/overwatch.dm Outdated Show resolved Hide resolved
code/modules/cm_marines/overwatch.dm Outdated Show resolved Hide resolved
code/modules/cm_marines/overwatch.dm Outdated Show resolved Hide resolved
code/modules/cm_marines/overwatch.dm Outdated Show resolved Hide resolved
code/modules/cm_marines/overwatch.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft August 3, 2023 16:45
@TheGamerdk TheGamerdk marked this pull request as ready for review August 3, 2023 17:46
code/modules/cm_marines/overwatch.dm Outdated Show resolved Hide resolved
code/modules/cm_marines/overwatch.dm Outdated Show resolved Hide resolved
code/modules/cm_marines/overwatch.dm Show resolved Hide resolved
code/modules/cm_marines/overwatch.dm Outdated Show resolved Hide resolved
@SupernovaXTS
Copy link
Contributor

When a non SL is assigned as aSL they are shown as dead

@SupernovaXTS
Copy link
Contributor

Removing multicam does not work

@TheGamerdk
Copy link
Contributor Author

Both issues fixed

@sg2002
Copy link
Contributor

sg2002 commented Aug 4, 2023

There's one feature that's been lost in the rework: ability toggle hide shipside or groundside marines. Was pretty useful to quickly gauge squad state.

Also, I feel like this UI is not as ergonomic as the old one, since it takes way more screen space now, but that's something I can get used to, I guess.

Another minor thing that I don't like is that how helmetless marine names get marked red. This color coding keeps confusing me that they're dead, since the same color used for the death state too.

P.S. Sorry for typing it here, but there seems to be no other feedback thread.

@morrowwolf
Copy link
Member

There's one feature that's been lost in the rework: ability toggle hide shipside or groundside marines. Was pretty useful to quickly gauge squad state.

Also, I feel like this UI is not as ergonomic as the old one, since it takes way more screen space now, but that's something I can get used to, I guess.

Another minor thing that I don't like is that how helmetless marine names get marked red. This color coding keeps confusing me that they're dead, since the same color used for the death state too.

P.S. Sorry for typing it here, but there seems to be no other feedback thread.

Constructive and thought out feedback is not going to be thrown out. This is good, don't make a habit out of it though shakes cane

In other news, I think multicam is awesome. Sadly, I don't think it's going to be able to work due to performance issues. Switching between overwatch consoles quickly is part of CIC gameplay and the load time is a stutter for some and a gnarly hang for seconds for others.

Will play with it some more just it's really important to be able to switch between cams rapidly and efficiently while also moving between consoles/squads. This UI must, at least, come close to the ease of use as the current UI.

@morrowwolf morrowwolf marked this pull request as draft August 5, 2023 14:49
@TheGamerdk TheGamerdk closed this Aug 6, 2023
@TheGamerdk
Copy link
Contributor Author

TheGamerdk commented Aug 6, 2023

If anyone wants to pick this up:

Make the squad list sorted by role (SL->FTL->Spec->SG -> Medic/Engi -> Marine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Make the code harder to read UI deletes nanoui/html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants