Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: snowing inside walls on Sorokyne Strata map. #4088

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

Huffie56
Copy link
Contributor

@Huffie56 Huffie56 commented Aug 2, 2023

About the pull request

fixes: #1496
change the area so it as a wall if this sort of wall is suppose to be some sort of wall that snow is falling on sprite should reflect it..

Explain why it's good for the game

it shouldn't snow inside walls? atleast i think it shouldn't...

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
maptweak: changing an area so it stop snowing inside walls.
/:cl:

@github-actions github-actions bot added the Mapping did you remember to save in tgm format? label Aug 2, 2023
@Huffie56 Huffie56 changed the title fix: snowing inside walls swap old area for the new with a celling. fix: snowing inside walls on Sorokyne Strata map. Aug 2, 2023
@Huffie56 Huffie56 marked this pull request as ready for review August 2, 2023 13:08
@Huffie56
Copy link
Contributor Author

Huffie56 commented Aug 2, 2023

image
i think it look better since the grey area is suppose to be non visible it's more a filler for the inside... so it shouldn't snow on it...

@Nanu308 Nanu308 added the Mapping Approved adds 500 new dict keys label Aug 7, 2023
Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Nanu308 Nanu308 added this pull request to the merge queue Aug 7, 2023
Merged via the queue into cmss13-devs:master with commit adf591e Aug 7, 2023
28 checks passed
cm13-github added a commit that referenced this pull request Aug 7, 2023
@Huffie56 Huffie56 deleted the strata_mountain_fix_area branch August 15, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sorokyne Strata sprite of snow in the wall
2 participants