-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds campfires #4091
Merged
Merged
Adds campfires #4091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Sprites
Remove the soul from the game.
Sound
Blast 5 minutes of bass boosted music to our players
Feature
Feature coder badge
Code Improvement
Make the code longer
labels
Aug 2, 2023
BeagleGaming1
commented
Aug 2, 2023
state = STATE_FUEL | ||
frame_type = /obj/structure/prop/brazier/frame/full/campfire | ||
|
||
/obj/structure/prop/brazier/campfire |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm considering moving this code up to /obj/structure/prop/brazier
harryob
requested changes
Aug 3, 2023
Co-authored-by: harryob <[email protected]>
Co-authored-by: harryob <[email protected]>
Co-authored-by: harryob <[email protected]>
FransFeiffer
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sprites look nice, here's a spriter approval 👍
harryob
approved these changes
Aug 4, 2023
cm13-github
added a commit
that referenced
this pull request
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Code Improvement
Make the code longer
Feature
Feature coder badge
Sound
Blast 5 minutes of bass boosted music to our players
Sprites Approved
confirmed no stray pixels
Sprites
Remove the soul from the game.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Adds campfires that provide heating to those nearby, while requiring fuel
Sprites and sound by Thwomper
Explain why it's good for the game
They look cool and will allow marines, and maps, to have campfires without using braziers
Changelog
🆑
add: Adds campfires, craftable with wood
code: Modifies brazier construction code for easier use and mapping
/:cl: