Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds and rebalances items #4103

Closed
wants to merge 4 commits into from
Closed

Conversation

Dorodomki
Copy link
Contributor

@Dorodomki Dorodomki commented Aug 3, 2023

About the pull request

adds a vest, medkit, hardhat for the mt's and the CE closets to help them out in the shift, limiting their gear as FOB reinforcements since any mt was able to grab a marine armor and fight as one, here i give them some gear to not make them look like a marine and have some differences in case they get deployed on FOB

adds one pouch slot more to the civilian m3 vest to leave it at the same storage level of other marine armors and making it a bit more useful

Explain why it's good for the game

adds some basic gear for the mt's being a medkit to fill the medkit pouch they have, a civilian vest if they are required in the FOB and a welder chestrig since they had to hack a surplus vendor to get them plus a blue hardhat to cover their heads and because it combines with the uniform colour

Changelog

🆑
add: adds a welder chestrig, basic medkit, civilian vest, blue hardhat to the mt's and chief engineer closets
balance: rebalances the civilian vest having one pouch
/:cl:

adds a vest, medkit, hardhat for the mt's and the CE to help them out in the shift, limiting their gear as FOB reinforcements since any mt was able to grab a marine armor and fight as one

adds one pouch slot more to the civilian m3 vest to leave it at the same storage level of other marine armors
Copy link
Member

@morrowwolf morrowwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those vests aren't for deployment purposes so no go on that.

Secondly, it has one storage slot because it's pretty damn fast, I see no reason to buff it.

@morrowwolf morrowwolf marked this pull request as draft August 3, 2023 20:14
rebalances the civilian vest into an normal bulletproof vest for the mt's and Chief engineers, adds medket to the CE
@Drulikar Drulikar added Feature Feature coder badge Balance You need to be a professional veteran game maintainer to comprehend what is being done here. labels Aug 3, 2023
@Drulikar
Copy link
Contributor

Drulikar commented Aug 3, 2023

In the changelog template, it intentionally has each line preceded with a type e.g. add: blah blah or balance: blah blah those are needed to generate the changelog because they indicate what kind of change it is. I have edited your changelog to reflect this, but should you change the scope of the pr be sure to update it.

Copy link
Member

@morrowwolf morrowwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No vests. They are USCM personnel, give them armor if you want to give them armor. Keep the hazard vest in there as well.

@Dorodomki
Copy link
Contributor Author

No vests. They are USCM personnel, give them armor if you want to give them armor. Keep the hazard vest in there as well.

they aren't marines to have the same gear as them, im thinking of more "civilian or old gear" used by them since they are engineers after all, their armor should be oriented towards ballistic protection instead of slashes and full body protection, that's my point in giving them ballistic vests

changes the previous vest for something less "defensive"
Copy link
Member

@morrowwolf morrowwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise fine

balances the storage of the lockers and adds the welder chestrig to the ce locker
@Dorodomki Dorodomki marked this pull request as ready for review August 9, 2023 05:02
Copy link
Member

@morrowwolf morrowwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing new in the chief engineer locker.

Put all of that stuff in the chief engineer vendor.

All of the new stuff placed in the engineer locker needs to be in the non-groundside section so we don't find random marine gear and such in civilian engineer lockers. Really there should be two different ones but I won't make you do that.

@morrowwolf morrowwolf marked this pull request as draft August 9, 2023 05:09
@Dorodomki
Copy link
Contributor Author

Nothing new in the chief engineer locker.

Put all of that stuff in the chief engineer vendor.

All of the new stuff placed in the engineer locker needs to be in the non-groundside section so we don't find random marine gear and such in civilian engineer lockers. Really there should be two different ones but I won't make you do that.

morrow they literally get an universal welder chestrig, medkit and nothing else what marine gear are you talking about dude, they aren't getting any marine gear.

@Dorodomki Dorodomki marked this pull request as ready for review August 9, 2023 05:53
@morrowwolf
Copy link
Member

Feel free to reopen when changes are complete.

@morrowwolf morrowwolf closed this Aug 9, 2023
@Dorodomki
Copy link
Contributor Author

this pr just added medkits, overalls, blue hazard helmets and a welder chestrig to the MT, CE lockers, deleted what you wanted and you really know how to motive people to developt for the game, im gonna do the changes for the last time because is something really cool develop here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants