Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combistick now uses a chain #4104

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Conversation

Zonespace27
Copy link
Contributor

@Zonespace27 Zonespace27 commented Aug 3, 2023

About the pull request

image

Pred combistick now uses a visible chain.

Balance ramifications:

  • Someone picking up the combi (still has a do_after for non-preds mind you) will sever the chain with a message to the pred
  • You can no longer yank any combi-stick regardless of if it's actually yours
  • Combistick will be pulled with you when you would get more than 6 tiles from it
  • You will automatically yank back a combistick that tries to get put into a container

Explain why it's good for the game

  • Preventing chain weirdness while still allowing it to be recovered by marines if the pred really isn't good about holding onto the combi
  • Side effect of me making the code a lot better
  • Side effect of the tether effect
  • Preventing chain weirdness

Changelog

🆑
add: Combisticks now use a proper chain instead of an invisible magic one.
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Aug 3, 2023
@Zonespace27 Zonespace27 added Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Whitelist Changes labels Aug 3, 2023
Copy link
Member

@realforest2001 realforest2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on the WL end.

@realforest2001 realforest2001 added this to the Yautja Rework milestone Aug 8, 2023
@harryob harryob added this pull request to the merge queue Aug 9, 2023
Merged via the queue into cmss13-devs:master with commit a84aec2 Aug 9, 2023
27 checks passed
cm13-github added a commit that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants