Hazmat Joe voicelines round 2 #4106
Conversation
github-actions
bot
added
Sound
| usr.emote(initial(path.key)) | ||
| return TRUE | ||
|
|
||
| /datum/species/synthetic/colonial/engi_joe |
There was a problem hiding this comment.
Really don't like how the hazard joe is a seperate species from working joe, it should at least be a subtype since it copies all of the stats except for small adjustments. This also likely needs to be accounted for in isworkingjoe define since it wouldnt be caught.
| path = text2path(params["emotePath"]) | ||
| slowdown = 0.6 // a bit slower in return for the buffs | ||
| total_health = 225 // a bit more beefy | ||
| mob_inherent_traits = list(TRAIT_SUPER_STRONG, TRAIT_INTENT_EYES, TRAIT_EMOTE_CD_EXEMPT, TRAIT_CANNOT_EAT, TRAIT_ENGI_JOE) |
There was a problem hiding this comment.
It really shouldn't be done as a trait. One thing you can do is making it a subtype, and add a variable to the working joe as to what kind of joe it is.
| /datum/species/synthetic/colonial/engi_joe/engi/handle_post_spawn(mob/living/carbon/human/joe) | ||
| . = ..() | ||
| give_action(joe, /datum/action/joe_emote_panel) | ||
|
|
||
| if(!(path in subtypesof(/datum/emote/living/carbon/human/synthetic/working_joe))) | ||
| return | ||
| /datum/species/synthetic/colonial/engi_joe/handle_death(mob/living/carbon/human/dying_joe, gibbed) | ||
| if(!gibbed) | ||
| playsound(dying_joe.loc, pick_weight(list('sound/voice/joe/death_normal.ogg' = 75, 'sound/voice/joe/death_silence.ogg' = 10, 'sound/voice/joe/death_tomorrow.ogg' = 10,'sound/voice/joe/death_dream.ogg' = 5)), 25, FALSE) | ||
| return ..() | ||
|
|
||
| COOLDOWN_START(src, panel_emote_cooldown, 2.5 SECONDS) | ||
| usr.emote(initial(path.key)) | ||
| return TRUE | ||
| /datum/species/synthetic/colonial/engi_joe/open_emote_panel() | ||
| var/datum/joe_emote_panel/ui = new(usr) | ||
| ui.ui_interact(usr) |
There was a problem hiding this comment.
Stuff like this is why it needs to be a subtype. so much repeated code... Perhaps you can have the engi_joe overright open_emote_panel and give it a argument that tells it to give it hazard joe voicelines?
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
About the pull request
Adds custom voicelines to the hazmat joe variant of the working joe as well as some minor tweaks to their durability
Explain why it's good for the game
Increases soul as the hazmat variant joes were quite literally built different, they are more durable and have a different voice box, both of which are emulated here
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
soundadd: New hazmat joe voicelines
balance: Hazmat joe has a minor increase to durability and burn resistance in return for being a bit slower
/:cl: