Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

just a little Vamp QoL #4116

Closed
wants to merge 1 commit into from

Conversation

Diegoflores31
Copy link
Contributor

@Diegoflores31 Diegoflores31 commented Aug 5, 2023

About the pull request

Adds Aim assist to Tail jab.

Explain why it's good for the game

Sprite clicking can be a little hard to land taking into consideration the current marine speed and as this is the main vamp weapon i gave it a little help in that matter .

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: Tail stab now provides aim assist ( you dont have to sprite click)
/:cl:

@github-actions github-actions bot added Quality of Life Make the game harder to play Refactor Make the code harder to read labels Aug 5, 2023
@Segrain
Copy link
Contributor

Segrain commented Aug 5, 2023

This is no QoL. This is essentially a revert of #2909 and is a pure balance change.
As an occasional vampire player, I might have an opinion on whether such change is needed, but nobody asked mine.

@Segrain Segrain added Balance You need to be a professional veteran game maintainer to comprehend what is being done here. and removed Quality of Life Make the game harder to play labels Aug 5, 2023
@Diegoflores31
Copy link
Contributor Author

Diegoflores31 commented Aug 6, 2023

This is no QoL. This is essentially a revert of #2909 and is a pure balance change. As an occasional vampire player, I might have an opinion on whether such change is needed, but nobody asked mine.

incorrect . #2909 had special effects for sprite clicking(x1.5 damage) and more stuff including a 2 tile telegraph and many more effects.

this is not a revert at all of that PR. just an aim assist and removal of remanent carlarc code that is no longer used

@Zonespace27
Copy link
Contributor

aim assist is in no uncertain terms a balance change

@thwompa

This comment was marked as off-topic.

@morrowwolf
Copy link
Member

No thanks!

@morrowwolf morrowwolf closed this Aug 6, 2023
@Diegoflores31 Diegoflores31 deleted the vampassist branch October 30, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Refactor Make the code harder to read
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants