Lights turn on at roundstart #4129
Conversation
| @@ -264,6 +264,10 @@ SUBSYSTEM_DEF(ticker) | |||
| INVOKE_ASYNC(C, TYPE_PROC_REF(/obj/structure/closet, select_gamemode_equipment), mode.type) | |||
| for(var/obj/structure/machinery/vending/V in machines) | |||
| INVOKE_ASYNC(V, TYPE_PROC_REF(/obj/structure/machinery/vending, select_gamemode_equipment), mode.type) | |||
| for(var/obj/structure/machinery/power/apc/apc in machines) | |||
There was a problem hiding this comment.
I hope this is the right place to put this
|
TM'ing so I can see how long 4-15 seconds really is with start up. I'll take a closer look at where in ticker you put this later |
| @@ -264,6 +264,10 @@ SUBSYSTEM_DEF(ticker) | |||
| INVOKE_ASYNC(C, TYPE_PROC_REF(/obj/structure/closet, select_gamemode_equipment), mode.type) | |||
| for(var/obj/structure/machinery/vending/V in machines) | |||
| INVOKE_ASYNC(V, TYPE_PROC_REF(/obj/structure/machinery/vending, select_gamemode_equipment), mode.type) | |||
| for(var/obj/structure/machinery/power/apc/apc in machines) | |||
There was a problem hiding this comment.
this should be an SSticker.OnRoundstart()
| @@ -156,11 +156,18 @@ GLOBAL_LIST_INIT(apc_wire_descriptions, list( | |||
| update_icon() | |||
| addtimer(CALLBACK(src, PROC_REF(update)), 5) | |||
|
|
|||
| if(is_mainship_level(z) && !(SSticker.current_state == GAME_STATE_PLAYING || SSticker.current_state == GAME_STATE_FINISHED)) | |||
| operating = 0 | |||
There was a problem hiding this comment.
these should be FALSE/TRUE defines
| start_processing() | ||
|
|
||
| if(!start_charge && is_ground_level(z) && prob(10)) | ||
| set_broken() | ||
|
|
||
| /obj/structure/machinery/power/apc/proc/late_activation() | ||
| operating = 1 |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
About the pull request
Lights on the ship are off when the round starts then turn on after 4 to 15 seconds
Explain why it's good for the game
https://www.youtube.com/watch?v=WCtkibZqSpk
Changelog
🆑
add: Ship lights turn on when the round starts
/:cl: