Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes *some* of the cave walls in the LV624 cave system to be jungle walls instead #4136

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

spartanbobby
Copy link
Contributor

@spartanbobby spartanbobby commented Aug 7, 2023

About the pull request

This PR changes some of the LV624 cave walls to be jungle walls

Explain why it's good for the game

Honestly I just think it looks pretty and mechanically nothing changes since those jungle walls are just as unbreakable as the cave ones, I implore reviewers to load this branch in game and check out the difference adding just a little more tile differentiation helps the caves visually

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
maptweak: Replaces some cave walls on LV624 with junglewalls (nothing will change gameplay wise)
/:cl:

@github-actions github-actions bot added the Mapping did you remember to save in tgm format? label Aug 7, 2023
@Huffie56
Copy link
Contributor

Huffie56 commented Aug 7, 2023

it look weird inside the caves... why not use the fiorina xeno walls that are indestructible? they look good and are better fit for inside the caves ....
while your at it you could try adding some slope to make an cave more interesting?

@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Aug 16, 2023
Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm map wise

@Nanu308 Nanu308 added Mapping Approved adds 500 new dict keys and removed Stale beg a maintainer to review your PR labels Aug 17, 2023
@Nanu308 Nanu308 added this pull request to the merge queue Aug 17, 2023
Merged via the queue into cmss13-devs:master with commit d90b6fb Aug 17, 2023
25 checks passed
cm13-github added a commit that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants