-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICC patch #4152
ICC patch #4152
Conversation
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
That's awesome! Thanks for adding this. I recommend you add it to the ICC survivors as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool idea but the sprite needs a little work
the outline stitching needs some redoing regarding the colors, mostly the top right and bottom left darker portions. the values are too similar and they blend together in a bad way
the two angled brackets between the moon and the moon itself need some shading work as well. look at the current in-game patches for more reference.
[this part isn't required but heavily suggested] i think it would benefit from having a more unique shape that "fits" the ICC logo. not all patches are basic circles after all :D. it also makes the design feel less cramped/gives the details room to breathe on the sprite
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Staled, re-open when review and conflicts are complete. |
About the pull request
Adds an ICC patch and provides it to the ICC Liaison for added lore. This will also come in handy if we later down the line want to delve into the ICC quarantining the ship during the zombies gamemode. See: 2157 New earth
Explain why it's good for the game
More fluff lore sprites is good.
Testing Photographs and Procedure
Tested and it all works fine.
Changelog
🆑 TopHatPenguin
add: Adds the Interstellar Commerce Commission (ICC) Patch. Currently only the ICC Liaison is equipped with it.
/:cl: