-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EVAC-3F & EVAC-3O Decoration Fighter Craft (USS Almayer & New Varadaro) #4158
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NV is not a USAF base. If you want to change the guns please do so in a different PR.
These sprites are kinda small four our perspective. Are these the ones Sammy had sprited? I remember them being bigger for some reason.
Can change the M39 element, sure. NV section of lore was moved to discord side for discussion, for outside perspective. For the dev stuff with the sprite, I'm not sure why they're so small ingame. They're bigger in the dmi, so perhaps something with the bound width and height? @nauticall or @thwompa might know how to fix that |
Changes requested should be done, with both the M39 and the fix of linters. I'll let you mark as fixed if you think so @morrowwolf |
If you undid the change about the guns, could you remove it from the changelog? |
u right |
The jet sprites feel like... way too small. We'll see what Sammy/Frans think but I can't imagine a 2x2 fighter being approved. It looks way out of place. |
Can we get code and mapping approval out of the way? I think there's something off with the sprites, but I think its how they're implemented, rather than the sprites themselves. Looking for naut's feedback on how to handle it, I doubt its her issue but something on my end |
Co-authored-by: Zonespace <[email protected]>
Co-authored-by: Zonespace <[email protected]>
Co-authored-by: Zonespace <[email protected]>
Should be good to resolve now and wait for Frans to take a look. At current, the EVAC-3s can be walked through. I think it's fine, for now, as it's a big craft and if you've been around something like this IRL you know you can go under it. It works fine for now, but in the future I might see if I can find a way to make the center itself unable to be walked through |
I'll go fix the trailing light in the hanger bay later but if I boot up my PC again I will not sleep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Descriptions of both fighters, along with the two supposedly severed hands require gramattical review.
Sure, I'm having the lore team do their own descs for them and then I'll add those + a refined blurb for it I love writing, but writing in strongdmm isn't my fine art 😆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright spent some time thinking about it.
Not a fan of the one on the Almayer. Go ahead and remove the Almayer changes. Doesn't sit right for me.
The New Varadero ones should be offset at least a bit. You don't want them perfectly symmetrical in the area it'll look funny.
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
About the pull request
Adds the EVAC-3 from the RPG as a fluff map vehicle, that is not actually drivable, similar to the tractor.
The EVAC-3 is added in both a USCM variant for the USS Almayer and a USAF variant for New Vardaro. On NV, it's featured around the airfield, with a limited number of craft with fluff items like a pilot's helmet and severed hand- and maintenance gear for a dropship.
As well as that, M39s and flight suits replace the M4RAs in the dorms in order to reinforce the fact that NV is a USAF station.
Explain why it's good for the game
This adds more RPG items into the game, without affecting game balance, more or less encouraging people to know more about the universe.
As well, as this adds a bit more decoration to an unused room in the Almayer and helps make the ship feel alive.
Testing Photographs and Procedure
Changelog
🆑 Misty
add: Adds the EVAC-3F as a USCM decoration fighter in the USS Almayer. This also adds a fighter-stowage bay by the pilot's office containing two of these fighters. Sprite by Naut.
add: Adds the EVAC-3O as map decoration on NV. It spawns around the airfield and has misc pilot gear around it- such as a flight recorder, flight helmet and M44 revolver. Sprite by Naut.
/:cl:>