Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible fix for binoc perma zoom #4176

Merged

Conversation

morrowwolf
Copy link
Member

@morrowwolf morrowwolf commented Aug 13, 2023

About the pull request

I have no consistent reproducibility for this but this may fix it? Seems to occur when an explosion blows up the binocs in the hand of the person while zoomed.

Explain why it's good for the game

Bug bad

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 Morrow
fix: Possible fix for binoc perma zoom
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Aug 13, 2023
@Huffie56
Copy link
Contributor

i think this would fixes this issue :
#3405
can you confirm?

@morrowwolf
Copy link
Member Author

i think this would fixes this issue : #3405 can you confirm?

Not 100% it'll fix it so we'll leave it for now

code/game/objects/items.dm Outdated Show resolved Hide resolved
code/game/objects/items.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft August 16, 2023 08:56
@morrowwolf morrowwolf marked this pull request as ready for review August 22, 2023 13:09
@harryob harryob added this pull request to the merge queue Aug 23, 2023
Merged via the queue into cmss13-devs:master with commit d260ac0 Aug 23, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants