Fix solaris ridge map link and refactor current_map #4192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Fix
harryob
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR fixes the discrepancy between maps and a current_map counterpart by removing the duplicate definitions. Additionally this will make mapped in maps work for solaris ridge, soro has its name/desc set to the latest edit, and the wiki example config is correct again.
Explain why it's good for the game
Fixes #4191 and makes it harder for discrepancies like this to occur again.
Testing Photographs and Procedure
Screenshots & Videos
Changelog
🆑 Drathek
fix: Fixed mapped in maps for solaris ridge not opening correctly.
refactor: Refactored current_map to use a global list instead to remove the need for duplicate definitions.
/:cl: