Fix cade attack speed exploit #4204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryob
approved these changes
Aug 18, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
cm13-github
added a commit
that referenced
this pull request
Aug 22, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 5, 2023
# About the pull request This PR is a followup to #4204 that introduced a cooldown to grabbing to fix an exploit. Unfortunately this broke logic for xeno grab intent click though because that logic pre-emptively is adjusting next_move (that xenos just override and ignore anyways), so now the cooldown check is added to just ctrl+click. Technically this means that human ctrl+click *could* be affected by this change, but I haven't currently found any effects of this. # Explain why it's good for the game Fixes #4244 # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> https://youtu.be/BMRnHIa967Q </details> # Changelog :cl: Drathek fix: Fixed xeno grab intent /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR fixes an exploit where dragging could be used to bypass an attack cooldown.
Explain why it's good for the game
Fixes #4184
Testing Photographs and Procedure
Screenshots & Videos
https://youtu.be/nIfXqQ6IBw0
Changelog
🆑 Drathek
fix: Fixed a cade attack exploit
/:cl: