Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attachment obliteration #4217

Merged
merged 4 commits into from
Aug 25, 2023
Merged

Conversation

Diegoflores31
Copy link
Contributor

@Diegoflores31 Diegoflores31 commented Aug 20, 2023

About the pull request

fixes #4194
Fixes weird behaviour with underbarrel fire extinguisher being able to be used one handed on some weapons but not on others

All attachable weapons will now require you to hold them with both hands in order to be used. (( added an exception flag for future attachies that may need it))

standarized error message you receive when you are not wielding an attachment.

Explain why it's good for the game

realism and standarized behaviour for all attachments

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: Masterkey and underbarrel extinguisher now must be wielded in order to be used.
fix: Underbarrel extinguisher no longer bypass wielding restrictions on flamers.
/:cl:

@github-actions github-actions bot added Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Fix Fix one bug, make ten more labels Aug 20, 2023
Copy link
Contributor

@Zonespace27 Zonespace27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting to this before me

code/modules/projectiles/gun.dm Outdated Show resolved Hide resolved
code/modules/projectiles/gun.dm Outdated Show resolved Hide resolved
code/modules/projectiles/gun.dm Outdated Show resolved Hide resolved
code/modules/projectiles/gun_attachables.dm Outdated Show resolved Hide resolved
code/modules/projectiles/gun_attachables.dm Outdated Show resolved Hide resolved
Copy link
Contributor

@Zonespace27 Zonespace27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought i submitted this earlier

code/modules/projectiles/gun.dm Outdated Show resolved Hide resolved
code/modules/projectiles/gun.dm Show resolved Hide resolved
code/modules/projectiles/gun_attachables.dm Outdated Show resolved Hide resolved
code/modules/projectiles/gun_attachables.dm Outdated Show resolved Hide resolved
code/modules/projectiles/gun_attachables.dm Outdated Show resolved Hide resolved
Copy link
Contributor

@Zonespace27 Zonespace27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@Zonespace27 Zonespace27 added this pull request to the merge queue Aug 25, 2023
Merged via the queue into cmss13-devs:master with commit 7051fa8 Aug 25, 2023
25 checks passed
cm13-github added a commit that referenced this pull request Aug 25, 2023
@Diegoflores31 Diegoflores31 deleted the attachies branch October 30, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flamers have to be wielded to use under barrel extinguishers
2 participants