-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General Quarters via ARES no longer cares if Red alert or not #4227
Merged
harryob
merged 7 commits into
cmss13-devs:master
from
Ben10083:General_Quarters_even_on_Red
Aug 29, 2023
Merged
General Quarters via ARES no longer cares if Red alert or not #4227
harryob
merged 7 commits into
cmss13-devs:master
from
Ben10083:General_Quarters_even_on_Red
Aug 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
UI
deletes nanoui/html
Quality of Life
Make the game harder to play
labels
Aug 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code Lgtm , UI dunno
harryob
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
ARES general quarter call no longer cares if it is Red Alert already, but has a 10 minute cooldown between uses
Explain why it's good for the game
Many been telling me how they like General Quarters, but usually can't use it as Red Alert has been called already, this makes it so it can still be used (albeit no mechanical effect), but a cooldown has been added to prevent spam.
Changelog
🆑
qol: General Quarters via ARES can now be called regardless of alert level.
/:cl: