fancy lighting #4229
Merged
fancy lighting #4229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
cm13-github
added a commit
that referenced
this pull request
Aug 28, 2023
3 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 26, 2024
# About the pull request Reverts the flare buff that came alongside fancy lighting from 7 range to 5 <!-- Remove this text and explain what the purpose of your PR is. Mention if you have tested your changes. If you changed a map, make sure you used the mapmerge tool. If this is an Issue Correction, you can type "Fixes Issue #169420" to link the PR to the corresponding Issue number #169420. Remember: something that is self-evident to you might not be to others. Explain your rationale fully, even if you feel it goes without saying. --> # Explain why it's good for the game Since the fancy lighting change, other factors have come in to play, most notably the rise in the flare gun, the increase in pouch storage and the buff to armour light, making controlling lighting incredibly easy just with 1, with them being infinitely more difficult to deal with than flashlights and a lot more accessible while being safer to use with other utility. I believe it is fair to revert the buff especially considering how bright flares are in real life, being more of a concentrated amount of light, not overpowering a military issue flashlight 10 fold without the cone effect to boot. With how considerable the nerf would be I doubt they will fall into the realm of uselessness, with them still being a great option for scouting ahead of what is visible and still being very easy to carry, just needing an additional flare or so for a room that would be lit up by one. # Testing Photographs and Procedure https://imgur.com/5VNOQrh <details> <summary>Screenshots & Videos</summary> Put screenshots and videos here with an empty line between the screenshots and the `<details>` tags. </details> # Changelog :cl: balance: Reverted flare range buff 7->5 tiles /:cl:
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 4, 2024
…w start in transit to the ship, and return to their very own ert home (#5802) title pretty much actually uses the maps added back in #3546 the lazy templates are made entirely by ZephyrTFA on /tg/, predominantly in tgstation/tgstation#71785 🆑 ZephyrTFA, harryob add: framework for new ert stations ported from tgstation/tgstation#71785, by ZephyrTFA add: distress beacons now start in transit to the ship, and will return to their own home base. they can't keep going back and forth between the ship and their base /:cl: this pr also unfucks base lighting, because i apparently did that really bad in #4229 --------- Co-authored-by: Drathek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was a long time coming
many thanks to:
tgstation/TerraGov-Marine-Corps#1964 for the lighting controller (A-lexa)
tgstation/TerraGov-Marine-Corps#4747 and tgstation/TerraGov-Marine-Corps#7263 for the lighting (TiviPlus)
tgstation/tgstation#54520 for the dir lighting component
tgstation/tgstation#75018 for the out of bounds fix in lighting
tgstation/TerraGov-Marine-Corps#6678 for the emissives (TiviPlus) (but this is still a
🆑 TiviPlus, A-lexa, SyncIt21, Azarak, harryob, MorrowWolf, Zonespace
add: shadows are now in the game, and light follows you.
/:cl: