Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wire cutter on a plant bug #4239

Closed
wants to merge 3 commits into from

Conversation

MikeKuwait
Copy link
Contributor

@MikeKuwait MikeKuwait commented Aug 23, 2023

About the pull request

Fixes #3367

Sampled plant's growth are reduced to a probability of 10 percent.

Explain why it's good for the game

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑

fix: Sampled plant's growth are reduced

/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Aug 23, 2023
@Diegoflores31
Copy link
Contributor

i dont think this is what the bug is refering to

@MikeKuwait
Copy link
Contributor Author

i dont think this is what the bug is refering to

In the bug issue it says that if the plant is sampled, it shouldn't make the plant growth. Unfortunately in the code, there is no proc that stops growth of a plant while also allowing it age. This is the only solution I came up with, unless there is something I didn't understand with the issue?

@Diegoflores31
Copy link
Contributor

the issue is that the act of sampling "suposedly" makes the plant age increase . the expected behaviour is that you should just sample and thats it ( and plant has a chance lot loose health and shit) . i am unsure if it is a real bug or not in the first place because it could be just coincidency .

@MikeKuwait
Copy link
Contributor Author

the issue is that the act of sampling "suposedly" makes the plant age increase . the expected behaviour is that you should just sample and thats it ( and plant has a chance lot loose health and shit) . i am unsure if it is a real bug or not in the first place because it could be just coincidency .

Oh I see what you mean now that I re-read the issue properly. I somehow read it as the plant should stop growing if sampled. Thanks for clarifying!

@MikeKuwait MikeKuwait closed this Aug 26, 2023
@MikeKuwait MikeKuwait deleted the wire-bug branch August 26, 2023 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug using a wire-cuter on a plant will create a sample but will increase the growth stage of the plant.
2 participants