ERT Request QOL #4267
Merged
ERT Request QOL #4267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryob
approved these changes
Aug 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Tells admins if a random ERT has already been sent in response to an ERT request. Useful for latejoin staff who may be unaware, or missed the initial one by happenstance.
Also refactors the ERT request into a proc to synchronise messages as it was duplicated in four different places.
Explain why it's good for the game
Some QOL to make it easier to tell the situation with ERTs is a good thing.
Testing Photographs and Procedure
Screenshots & Videos
Changelog
🆑
code: Moved the Request ERT message to a proc to reduce duplication.
admin: Added a detail in ERT request to indicate if a RANDOM ERT was granted by staff already or not. This will not work for manual specific chosen ERTs.
/:cl: