Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icon2html optimizations #4287

Merged
merged 3 commits into from
Sep 9, 2023
Merged

Conversation

harryob
Copy link
Member

@harryob harryob commented Aug 30, 2023

thanks kylerace on tgstation/tgstation#67429
thanks lemoninthedark on tgstation/tgstation#58607

🆑 kylerace, lemoninthedark, harry
refactor: optimized icon-in-chat code
fix: weird icons on the smoothed walls when examining or alt+clicking
/:cl:

@github-actions github-actions bot added Refactor Make the code harder to read Fix Fix one bug, make ten more labels Aug 30, 2023
@Drulikar

This comment was marked as outdated.

@harryob
Copy link
Member Author

harryob commented Aug 30, 2023

What about the changes to asset_cache_item and asset_transport.dm? https://github.com/tgstation/tgstation/pull/67429/files?diff=unified&w=0#diff-4362e371a0951506a2892bc670f7af2025aa5c4f1c6f8b9e9c5a22262366ab53R30

i am dumb and forgot to commit both my stashes

Copy link
Member

@fira fira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm, anything that cuts down on md5asfile usage is good too...

@morrowwolf morrowwolf added this pull request to the merge queue Sep 9, 2023
Merged via the queue into cmss13-devs:master with commit c3c08ad Sep 9, 2023
25 checks passed
cm13-github added a commit that referenced this pull request Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more Refactor Make the code harder to read
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants