Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surgical drop pouch #4311

Closed
wants to merge 2 commits into from
Closed

Conversation

Sulaboy
Copy link
Contributor

@Sulaboy Sulaboy commented Sep 2, 2023

About the pull request

Adds a reskinned surgical vest based off of the drop pouch sprites, currently only obtainable as an accessory choice within the synthetic vendor.

Explain why it's good for the game

The surgical vest covers up shirt sprites. Some players have expressed wanting to show the shirt sprites off more, but still be able to carry surgical tools.

Testing Photographs and Procedure

Screenshots & Videos

imagdasdae

Changelog

🆑
add: Adds the surgical drop pouch item. It comes in green and blue like the surgical vest. Only currently available from synthetic vendor.
imageadd: Adds sprites for the drop pouches.
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Feature Feature coder badge labels Sep 2, 2023
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Sep 8, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

@nauticall nauticall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Sprite lacks volume from the front (left, red line); it looks flat and looks more like a fabric strip than a bag. From the back, though (right, red shape), it actually does have volume and does look like a pouch. Would recommend you correct the front-facing sprite to be more like the back and have volume; have it stick outta the body a little and look like it actually carries stuff.

@nauticall nauticall marked this pull request as draft September 11, 2023 08:48
@morrowwolf
Copy link
Member

Staled, re-open when review and conflicts complete.

@morrowwolf morrowwolf closed this Sep 26, 2023
github-merge-queue bot pushed a commit that referenced this pull request Oct 2, 2023
# About the pull request

Continuation of #4311 All credit where its due.

Adds a reskinned surgical vest based off of the drop pouch sprites,
currently only obtainable as an accessory choice within the synthetic
vendor.

Adds a Green, Blue and Black version of the pouch. 

The sprites size issues were addressed. 

# Explain why it's good for the game

The surgical vest covers up shirt sprites. Some players have expressed
wanting to show the shirt sprites off more, but still be able to carry
surgical tools


# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

![Screenshot 2023-09-23 23 39
25](https://github.com/cmss13-devs/cmss13/assets/6595389/3896f943-fa92-4ec9-aed7-f75422b20090)

</details>


# Changelog
:cl: Sulaboy, Hidgamer, Steelpoint
add: Adds the surgical drop pouch item. It comes in green, blue and
black. Only available from the synthetic vendor currently.
imageadd: Adds sprites for the surgical drop pouches.
/:cl:

Co-authored-by: Steelpoint <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Merge Conflict PR can't be merged because it touched too much code Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants