Possible fix for double dropship landing sound

[morrowwolf]

About the pull request

From time to time I will hear two landing sounds when landing in a dropship.

I believe this is the cause of it as the landing sound should be handled by on_prearrival() at line 551 of code/modules/shuttle/shuttle.dm

Explain why it's good for the game

Bug bad

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 Morrow
fix: Possible fix for double dropship landing sound
/:cl:

[Drulikar]

The first iteration of the new landing sound only worked on the almayer and not for the passengers. So either this is an observer issue, or there's a timing issue where sometimes the dropship is on the landing site z level and other times not when the sound gets played.

From the blame it was introduced here: #2733

[Drulikar]

This change seems to make it so passengers on the dropship no longer have a landing sfx. There is only a landing sfx for people at the landing site.

[morrowwolf]

HMMMMM, maybe it is just an observer situation