Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qol reorganize and update all the squads vendors. #4324

Merged
merged 7 commits into from
Sep 21, 2023

Conversation

Huffie56
Copy link
Contributor

@Huffie56 Huffie56 commented Sep 3, 2023

About the pull request

1-more categories
2-making the same organization category and order in all the squad marines vendors.(easier to navigate when changing roles.)
3-remove a bunch of holster being sell when you can choose them for free...

Explain why it's good for the game

1-making it easier for the players to navigate in squads vendors.
2-remove trap item that are being sold.
3-adding items that could be sold...

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
qol: reorganize and update all the squads vendors to add new categories(helmet optics, pamphlets, clothing items).
balance: remove hostler because it was available for free(for medic, squad-tl,.
balance: added possibility to buy M4 Pattern Armor for rifleman.
balance: added possibility to buy USCM Radio Telephone Pack for squad medic, engi and specialist.
balance: added possibility to buy Welding Visor for medic, SL, rifleman, smartgunner and specialist.
/:cl:

@Huffie56
Copy link
Contributor Author

Huffie56 commented Sep 3, 2023

VERY WIP mainly here so people know i am working on it.
up to review at the end of the day hopefully...

@github-actions github-actions bot added Quality of Life Make the game harder to play Balance You need to be a professional veteran game maintainer to comprehend what is being done here. labels Sep 3, 2023
@BeagleGaming1
Copy link
Contributor

Could you list what items are being added and removed instead of it just being "for consistency"?

@Huffie56
Copy link
Contributor Author

Huffie56 commented Sep 3, 2023

Could you list what items are being added and removed instead of it just being "for consistency"?

done

@Huffie56 Huffie56 marked this pull request as ready for review September 3, 2023 19:27
@Huffie56
Copy link
Contributor Author

Huffie56 commented Sep 4, 2023

i am in need of head dev directions concerning some items that are available freely on the squad prep or in medbay but are costing points in vendor.
wish confuse me greatly

@Huffie56
Copy link
Contributor Author

Huffie56 commented Sep 5, 2023

example being mini extinguisher that is free in vendor but cost 5 for rifleman....
lot's of more items in the same case
i personally think that we should be way more clear on what cost point and should be behind a pay wall and what shouldn't ...
we shouldn't make noob trap...

@Huffie56
Copy link
Contributor Author

Huffie56 commented Sep 8, 2023

Copy link
Member

@morrowwolf morrowwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine otherwise

@morrowwolf morrowwolf marked this pull request as draft September 9, 2023 02:46
@Huffie56 Huffie56 marked this pull request as ready for review September 9, 2023 12:05
@morrowwolf morrowwolf marked this pull request as draft September 21, 2023 08:36
@Huffie56 Huffie56 marked this pull request as ready for review September 21, 2023 08:49
@morrowwolf morrowwolf added this pull request to the merge queue Sep 21, 2023
Merged via the queue into cmss13-devs:master with commit c66860e Sep 21, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Sep 21, 2023
@Huffie56 Huffie56 deleted the qol_cleancleansquadvendors branch September 21, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Quality of Life Make the game harder to play
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants