Ship vs ship revival #4326
Closed
Ship vs ship revival #4326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Feature
Zonespace27
requested changes
Sep 3, 2023
Comment on lines
+19
to
+30
| GLOBAL_LIST_INIT(ship_hits_tally, list( | ||
| "times_hit_missile" = 0, | ||
| "times_hit_railgun" = 0, | ||
| "times_hit_odc" = 0, | ||
| "times_hit_aaboiler" = 0, | ||
| )) | ||
|
|
||
| //Ship's HP! ShipvsShip baybeee | ||
| GLOBAL_LIST_INIT(ship_health_vars, list( | ||
| "ship_hull_health" = 100, | ||
| "ship_systems_health" = 100, | ||
| )) |
There was a problem hiding this comment.
i feel like the ship being a datum is better
| @@ -97,6 +97,66 @@ | |||
| addtimer(CALLBACK(GLOBAL_PROC, GLOBAL_PROC_REF(weaponhits), 2, picked_atom, point_defense), hiteta SECONDS) | |||
| message_admins("[key_name_admin(src)] Fired a single Railgun Slug at the Almayer at a random location, [picked_atom], with the possibility of missing as [point_defense]") | |||
|
|
|||
| if("Orb. Def. Cannon") | |||
| if(exactplace == TRUE) | |||
There was a problem hiding this comment.
you can just do if(exactplace) for truthy and if(!exactplace) for falsey
| if("Orb. Def. Cannon") | ||
| if(exactplace == TRUE) | ||
| shipwide_ai_announcement("DANGER: ORBITAL DEFENSES ENGAGING, INCOMING SHOT. BRACE, BRACE, BRACE. ESTIMATED TIME: [hiteta] SECONDS." , MAIN_AI_SYSTEM, 'sound/effects/missile_warning.ogg') | ||
| addtimer(CALLBACK(GLOBAL_PROC, GLOBAL_PROC_REF(weaponhits), 3, mob.loc, point_defense), hiteta SECONDS) |
There was a problem hiding this comment.
do you know that the mob's loc will always be a turf?
There was a problem hiding this comment.
Would be misuse if it wasn't, it's for an admin to aim it at somewhere in a ship (Which kinda most certainly gonna be a turf) and then firin' it
| @@ -16,6 +22,7 @@ | |||
| * * salvo - identifies it as a salvo or not. | |||
| */ | |||
| /proc/weaponhits(weaponused, location, point_defense = FALSE, salvo = FALSE) | |||
| var/logtotalhits | |||
|
|
|||
|
|
|||
| switch(weaponused) | |||
There was a problem hiding this comment.
everything in this file (weapons, what they do for damage, etc.) should 100% be datums
|
Staled, re-open when review is complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This mnay not be Creedence Clearwater, but I'm damn sure it's a revival!
Starts a bit more of work into the Ship vs Ship systems already implemented!
Explain why it's good for the game
Ship vs Ship makes Shipside people go yay.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
add: Added 3 new weapons to smack the ship with.
del: Nuked the Red Alert restriction that was on the General Quarters code for good.
refactor: Made the General Quarters call itself a standalone proc.
admin: Adds a panel to check the ship's health for Staff.
/:cl: