Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restore old dmifiles to avoid missing sprite. #4327

Closed

Conversation

Huffie56
Copy link
Contributor

@Huffie56 Huffie56 commented Sep 3, 2023

About the pull request

Explain why it's good for the game

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
fix: restore old dmi files to avoid missing sprite(black tiles).
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Fix Fix one bug, make ten more labels Sep 3, 2023
@Huffie56 Huffie56 marked this pull request as ready for review September 3, 2023 17:01
@morrowwolf
Copy link
Member

Missing:
West LZ1 on Fiorina
image

North LZ2 on Fiorina
image

South LZ2 on Fiorina
image

Southwest LZ2 on Fiorina
image

And like... so much more. Just fly around Fiorina you'll find a ton.

In the mean time I've put up a revert for testmerging. #4332

@morrowwolf morrowwolf marked this pull request as draft September 4, 2023 06:50
@Huffie56
Copy link
Contributor Author

Huffie56 commented Sep 4, 2023

yes note to myself never remove original dmi....
such a pain to fix...
not againt's just reverting the all change i made....

@Huffie56
Copy link
Contributor Author

Huffie56 commented Sep 4, 2023

that make me realize i can't refactor the code this way i need to really think about how i want to approach it...

@Huffie56 Huffie56 marked this pull request as ready for review September 4, 2023 09:34
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Sep 8, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Huffie56 Huffie56 closed this Sep 8, 2023
@Huffie56 Huffie56 deleted the fix_restore_old_dmifiles branch September 21, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more Merge Conflict PR can't be merged because it touched too much code Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants