Fix hugger/lesser drone time of death bypass #4334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drulikar
approved these changes
Sep 4, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
cm13-github
added a commit
that referenced
this pull request
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Should fix the bypass_time_of_death_checks variable which is supposed to allow facehuggers and lesser drones to be eligible for larva queue even if they have recently died.
NOTE: I have no idea how to test this locally since for some reason I just cannot get larva queue to work locally at all (even when I haven't changed any code). I figured I'd put this PR up anyway and maintainers can take a look at it, but it may or may not actually work.
Explain why it's good for the game
It was clearly intended that ghosts of lesser drones and face huggers (and anything else with bypass_time_of_death_checks set to true) will bypass the time of death check when the game checks for larva queue candidates. I think because of how the logic was written it never actually worked properly unless you were an admin.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
fix: Hugger and Lesser Drone ghosts now actually bypass time of death checks for the larva queue.
/:cl: