Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncommented "Observe" verb #4345

Merged
merged 5 commits into from
Sep 19, 2023
Merged

Conversation

BeagleGaming1
Copy link
Contributor

@BeagleGaming1 BeagleGaming1 commented Sep 6, 2023

About the pull request

Apparently, there was an exploit with it, but I have been unable to reproduce it
(This will most likely need a test merge just in case)

Explain why it's good for the game

It's qol, it has no effect on anything beyond allowing observers to spectate better

Changelog

🆑
add: Uncommented the "Observe" verb for ghosts, allowing ghosts to see from a humans HUD
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Sep 6, 2023
@BeagleGaming1 BeagleGaming1 added the Needs Testing Need to test it on the guinea pigs (production server) label Sep 6, 2023
@BeagleGaming1 BeagleGaming1 marked this pull request as ready for review September 6, 2023 01:10
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-implement autoObserve on the orbit meni

@harryob harryob marked this pull request as draft September 6, 2023 14:53
@koltoast
Copy link

koltoast commented Sep 6, 2023

@BeagleGaming1 please read #615 including the comments

@BeagleGaming1
Copy link
Contributor Author

@BeagleGaming1 please read #615 including the comments

Yes I know the exploit, I am unable to reproduce it

@BeagleGaming1 BeagleGaming1 marked this pull request as ready for review September 7, 2023 01:23
@morrowwolf
Copy link
Member

Overlays on items do not seem to be updating, neither does the toggle clothing button in the bottom left
Anything in hand when you first observe them seems to not render correctly

@morrowwolf morrowwolf marked this pull request as draft September 8, 2023 14:48
@morrowwolf morrowwolf marked this pull request as ready for review September 19, 2023 09:28
@morrowwolf
Copy link
Member

Alright this has issues but honestly all of HUD code would likely need to be changed. Just going to call this a success with some slight problems for the time being. Seems most exploits have been fixed but we'll keep an eye out.

@morrowwolf morrowwolf added this pull request to the merge queue Sep 19, 2023
Merged via the queue into cmss13-devs:master with commit ecac37c Sep 19, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Sep 19, 2023
@BeagleGaming1 BeagleGaming1 deleted the observer-buff branch September 22, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Needs Testing Need to test it on the guinea pigs (production server)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants