Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
I filled this in bottom to top just read the explain why its good and changelog it has literally everything
Explain why it's good for the game
Presets to fill already existing ranks and complete the UPP officer corps, no reason not to.
Kapitan serves as non-WLed XO, without the BE skill and tool, Maj-Kol serve as CO ranks with possibility of including CO council status in UPP CO roles, General roles for event purposes and the ranks already existed in-code.
Conscript having its own rank being "conscript" makes it more of a meme role, vast majority of UPP soldiers are conscripts lore-wise anyway so doesn't make sense, making them E1 with standard soldiers being E2 makes more sense and cleans up ranks a bit.
UPP rank code had multiple redundant ranks, O1 and O1M for the same rank, but just doctors and normal LTs, no actual mechanical difference, same with E3S and E3M, sapper and medic, acted the exact same ingame but separated ranks for no reason and makes potentially adding new roles a bit harder.
Changelog
🆑
add: Adds upp presets for the unused officer ranks, Kapitan, Lt Kolonel, MajGen, LtGen, Gen, for use in admin events
add: Changes UPP conscript rank from weird conscript only rank to Private, moves UPP soldier to PFC, removing the rank gap between soldier and support
code: Cleans up UPP rank code by deleting redundant ranks
/:cl: