Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes lifepods still working after evac canceled #4392

Merged
merged 3 commits into from
Sep 13, 2023

Conversation

morrowwolf
Copy link
Member

@morrowwolf morrowwolf commented Sep 11, 2023

About the pull request

This PR fixes lifepods still being operational after evac has been canceled.

Explain why it's good for the game

Lifepods should not work if evac is canceled.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 Morrow
fix: Fixed lifepods still working after evac canceled
/:cl:

@github-actions github-actions bot added UI deletes nanoui/html Fix Fix one bug, make ten more labels Sep 11, 2023
@TheGamerdk
Copy link
Contributor

This should be checked on the DM side too, else you're open to HREF exploits

Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above

@harryob harryob marked this pull request as draft September 12, 2023 10:48
@morrowwolf morrowwolf marked this pull request as ready for review September 12, 2023 15:19
@harryob harryob added this pull request to the merge queue Sep 13, 2023
Merged via the queue into cmss13-devs:master with commit a4f8936 Sep 13, 2023
25 checks passed
cm13-github added a commit that referenced this pull request Sep 13, 2023
@morrowwolf morrowwolf deleted the lifepod-cancel-evac-fix branch September 13, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more UI deletes nanoui/html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants