Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working Joe Respawns #4429

Closed
wants to merge 7 commits into from

Conversation

Ben10083
Copy link
Contributor

@Ben10083 Ben10083 commented Sep 17, 2023

About the pull request

Working Joes can respawn after 10 minutes

Explain why it's good for the game

The restriction on Working Joes being unable to play as Working Joe again (for example if they cryo) is unnecessary. This change allows Joes to spawn after 10 minutes since death (still locked from respawns as before during hijack)

Changelog

🆑
add: Working Joes can now respawn after 10 minutes
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Sep 17, 2023
@Ben10083 Ben10083 changed the title Working joe respawns Working joe Respawns Sep 17, 2023
@Ben10083
Copy link
Contributor Author

Tried to find a way so if someone observes in first 10 minutes, they can spawn as Working Joe, no easy way and its pretty niche, so should be fine.

@Ben10083 Ben10083 marked this pull request as ready for review September 18, 2023 00:15
@Ben10083 Ben10083 changed the title Working joe Respawns Working Joe Respawns Sep 18, 2023
@realforest2001 realforest2001 marked this pull request as draft September 18, 2023 01:38
@Ben10083 Ben10083 marked this pull request as ready for review September 18, 2023 02:52
@morrowwolf morrowwolf added the Do Not Merge If you merge this PR, I will annihilate you label Sep 20, 2023
@morrowwolf
Copy link
Member

Not a fan. Apologies.

@morrowwolf morrowwolf closed this Sep 26, 2023
@Ben10083 Ben10083 deleted the Working_Joe_Respawns branch September 29, 2023 03:34
github-merge-queue bot pushed a commit that referenced this pull request Mar 26, 2024
# About the pull request

Redo of #4429 and #4795, done
after someone requested I revive the revived PR.

15 minute respawns for Working Joes, they can still be revived and still
have to follow other limits such as job limits and admin locks.

# Explain why it's good for the game

Working Joes being able to respawn allows for a Joe player to still
participate in the round as a Working Joe, even if they died as a Joe
before. This should only really have an impact if the Joe died before
hijack and will not be revived.

# Changelog
:cl:
add: Working Joes can now respawn as a Working Joe after 15 minutes,
previous restriction on respawn removed.
admin: New flag to disable Working Joe respawns
/:cl:

---------

Co-authored-by: Ben10083 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge If you merge this PR, I will annihilate you Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants