Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a Commissary to the Hangar #4447

Closed
wants to merge 2 commits into from

Conversation

HeresKozmos
Copy link
Contributor

@HeresKozmos HeresKozmos commented Sep 19, 2023

About the pull request

Adds a small self-serve commissary to the hangar.

Explain why it's good for the game

The old panic room which this is replacing was never used so I decided to replace it with a more useful room, this commissary has the five main vendors (RecVend, Hot Drinks, Snacks, Smokes and Souto) all in one place and the intent is to have an area right in the hangar where returning/departing marines can grab things such as a walkman, cigarettes or whatever else they wish.

I believe this to be much more useful than the old panic room which I have never seen actually be used in-game at all.

Testing Photographs and Procedure

I ran it locally, the disposal and vent systems both work as intended and the vendors all work as intended,

image

Changelog

🆑
mapadd: added a commissary accessible in the hangar
/:cl:

@github-actions github-actions bot added the Mapping did you remember to save in tgm format? label Sep 19, 2023
Copy link
Member

@morrowwolf morrowwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs area and APC

@morrowwolf morrowwolf marked this pull request as draft September 27, 2023 21:26
@Huffie56 Huffie56 added this to the USS Almayer Updates/Changes milestone Sep 28, 2023
@QuickLode
Copy link
Contributor

QuickLode commented Sep 28, 2023

I would disagree with the panic room being never used - it was good for dropship incursions if you were nearby.

It is also good as a holding cell for localized prisoners.

The comissary just includes a bunch of vendors which would otherwise be found in other places of the ship. I also feel like the cramped space isn't very conducive to RP since you can only fit two or so people comfortably until you start blocking people :(

@Huffie56

This comment was marked as off-topic.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Oct 17, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@HeresKozmos HeresKozmos deleted the MiniStore branch October 28, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mapping did you remember to save in tgm format? Merge Conflict PR can't be merged because it touched too much code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants