kills hardcoded rule defines #4449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cm13-github
added
the
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
cm13-github
removed
the
Merge Conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
BeagleGaming1
approved these changes
Sep 23, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 6, 2023
# About the pull request This PR is a followup to the issues created by #4449 fixing job entry_message_body links to the wiki. /datum/controller/configuration now has a variable `is_loaded` that can be checked to see if configuration has already occurred such as the case for the ASO where subsequent creations of the job datum were not hitting the proc that would be called on the config load signal. # Explain why it's good for the game Broken wiki links harm the new player experience. # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary>    </details> # Changelog :cl: Drathek fix: Fixed various job's entry messages having broken links to the wiki /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i dont like having our url in defines we shouldnt have to change the code if a link changes
no playerfacing changes