Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prop gun effect #4450

Merged
merged 8 commits into from
Sep 23, 2023
Merged

Prop gun effect #4450

merged 8 commits into from
Sep 23, 2023

Conversation

BeagleGaming1
Copy link
Contributor

@BeagleGaming1 BeagleGaming1 commented Sep 20, 2023

About the pull request

Adds an effect for a prop gun, where you enter the type path as its variable and it automatically makes it look like the gun but unusable

(Codersprites should only be visible in mapping)

Explain why it's good for the game

Makes it easier to map in destroyed or non-functional guns

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Added a mapping effect for prop guns
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Mapping did you remember to save in tgm format? Feature Feature coder badge labels Sep 20, 2023
Copy link
Contributor

@sleepynecrons sleepynecrons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rare acceptable codersprite

@sleepynecrons sleepynecrons added the Sprites Approved confirmed no stray pixels label Sep 21, 2023
@harryob harryob added this pull request to the merge queue Sep 23, 2023
Merged via the queue into cmss13-devs:master with commit ba78ea1 Sep 23, 2023
25 checks passed
cm13-github added a commit that referenced this pull request Sep 23, 2023
@BeagleGaming1 BeagleGaming1 mentioned this pull request Oct 8, 2023
github-merge-queue bot pushed a commit that referenced this pull request Oct 9, 2023
# About the pull request

Fix to #4450
<!-- Remove this text and explain what the purpose of your PR is.

Mention if you have tested your changes. If you changed a map, make sure
you used the mapmerge tool.
If this is an Issue Correction, you can type "Fixes Issue #169420" to
link the PR to the corresponding Issue number #169420.

Remember: something that is self-evident to you might not be to others.
Explain your rationale fully, even if you feel it goes without saying.
-->

# Explain why it's good for the game
It should probably have copied the overlay for mags and attachments too

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl:
code: prop guns will copy attachments
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Mapping did you remember to save in tgm format? Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants