Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPP Survivors Use Player Names + Radio Change #4461

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

Steelpoint
Copy link
Contributor

@Steelpoint Steelpoint commented Sep 21, 2023

About the pull request

UPP survivors now default to using the players preferred name instead of a random UPP name.

The UPP radio name is now changed to "173/RECON" from "UPP 173rd Recon".

Explain why it's good for the game

The radio change is to make the radio text log less cumbersome to observe.

The name change was a requested change from the maintainers, as players should be using their preferred name instead of being forced to use a random one.

(On that note, if anyone has the coding skills, please put up a PR to let players select their own name for non-USCM spawns, guaranteed to be approved)

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: UPP survivor radio role identifiers now have a shorter title.
add: UPP survivors now default to using a players preferred name instead of a random UPP name.
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Sep 21, 2023
@realforest2001
Copy link
Member

Neither of these are balance related.
Also the title isn't specific to their own radios, it's just their role identifier. Worth tweaking the CL to reflect this.

@realforest2001 realforest2001 marked this pull request as draft September 22, 2023 02:36
@Steelpoint Steelpoint marked this pull request as ready for review September 22, 2023 02:46
@Steelpoint
Copy link
Contributor Author

Done.

@BeagleGaming1 BeagleGaming1 added Feature Feature coder badge and removed Balance You need to be a professional veteran game maintainer to comprehend what is being done here. labels Sep 22, 2023
Copy link
Contributor

@BeagleGaming1 BeagleGaming1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPP survivors now default to using a players preferred name instead of a random UPP name.

Unable to reproduce, the character randomizes when I select one of the Survivor - UPP equipment presets.

@BeagleGaming1 BeagleGaming1 marked this pull request as draft September 22, 2023 23:10
@Steelpoint
Copy link
Contributor Author

Missed a thing, fixed.

@Steelpoint Steelpoint marked this pull request as ready for review September 23, 2023 03:34
Copy link
Member

@morrowwolf morrowwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing synth comm title in synths.dm line 469

@morrowwolf morrowwolf marked this pull request as draft September 26, 2023 09:48
@Steelpoint Steelpoint marked this pull request as ready for review September 26, 2023 12:12
@Steelpoint
Copy link
Contributor Author

Fixed

@morrowwolf morrowwolf added this pull request to the merge queue Sep 26, 2023
Merged via the queue into cmss13-devs:master with commit c647d22 Sep 26, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Sep 26, 2023
@Steelpoint Steelpoint deleted the UPPSurvUpdate2 branch July 17, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants