Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Almayer: Dirty Up The Ship (Revival) #4476

Closed
wants to merge 2 commits into from

Conversation

Steelpoint
Copy link
Contributor

@Steelpoint Steelpoint commented Sep 23, 2023

About the pull request

Had to open a new PR to fix some issues, but essentially this is the same PR as #4089

Only difference is I ditched the concept of the broken sentry guns. I also attended to the prior requested changes requested in the last PR


Transforms the lower decks maintenance areas into a far more dirty, disorganized, area to be in. Emphasizing how many areas of the ship are in dire need of drydock repairs.

Sees the addition of a old 'tank repair bay' in one of the empty hanger rooms. Featuring a broken tank.
Also sees the addition of a 'ammo storage room' north of briefing. Featuring all of the ships remaining HEAP magazines and SADARs.

I hope to get to the upper deck in a separate PR.

(There should not be any actual real hidden HEAP ammo or anything akin to that.)

Major Things Worth Mentioning

The 'ammo store room' contains a lot of empty HEAP magazines and several SADARS and L42A's, the SADARS and guns are props and are non-functional. There is a single "HEAP" magazine with 5 bullets in it, but the bullets are standard rounds, with the magazine explicitly stating this.
The items in the Tank bay are all props, no tank gear is useable except for the Tanker helmet.

Explain why it's good for the game

Aesthetics.

The Almayer is intended to be a ship in very desperate need of repairs. Transforming the unused areas of the ship into a more derelict apperance may help impart this to the player.

No major balance change has been effected to these maint areas. Aside from being more cluttered and dank.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
maptweak: Lower deck maint of the Almayer is significantly more run down.
maptweak: Tank repair bay has been placed in the north-east of hanger. Behold the Tank in all its glory.
maptweak: Ammo storage room can be found north of briefing. All the remaining HEAP magazines can be found there.
/:cl:

@github-actions github-actions bot added the Mapping did you remember to save in tgm format? label Sep 23, 2023
@koltoast
Copy link

seems to contradict both #4440 and #4531

Copy link
Member

@morrowwolf morrowwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tank bay, probably going to end up with a storeroom or something there instead

@morrowwolf morrowwolf marked this pull request as draft September 27, 2023 21:28
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Sep 28, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Huffie56 Huffie56 added this to the USS Almayer Updates/Changes milestone Sep 28, 2023
@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Oct 19, 2023
@Steelpoint
Copy link
Contributor Author

Hate merge conflicts, think I'll just put this on the backburner since every time I think I fix the PR, something comes along and causes a merge conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mapping did you remember to save in tgm format? Merge Conflict PR can't be merged because it touched too much code Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants