Keycard authenticator can call ERT winout admin intervention

[Diegoflores31]

About the pull request

Fixes #4333

the keycard authentication will now show an option to send a distress signal similar to the almayer control console that will allow to call the FIRST distress signal on the almayer winout the need for admin approval . ( only works on red alert)

Explain why it's good for the game

Gives more options to lowpop command and provides a unique reward for using the authenticator in CIC instead of callling ERT remotely from lifeboats.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Adds a new way to send a Distress signal with the Keycard authenticator.
fix: Removes non functional "Call ERT" button in Keycard authenticator.
/:cl:

[ghost]

If that's the only time is_ert_blocked() is even used you might just want to shove that logic into call_ert() and simply return.

[morrowwolf]

Auto ERTs isn't gonna fly.

It still needs admin approval.

[Diegoflores31]

Auto ERTs isn't gonna fly.

It still needs admin approval.

but it only works for the first ERT . cannot be used more than once

[morrowwolf]

If you keep it to post hijack and it works the same way for every way to call an ERT it can be a free one but it should give an opportunity for staff to cancel it and extra credit for a button somewhere to pre-toggle it off.

[Diegoflores31]

Ok

[Diegoflores31]

If you keep it to post hijack and it works the same way for every way to call an ERT it can be a free one but it should give an opportunity for staff to cancel it and extra credit for a button somewhere to pre-toggle it off.

Changes applied:
-staff will have 15 seconds to cancel the ERT request . if it goes unanswered for more than that it will automatically approve
-If distress i called before hijack it will just call a standart ERT request,
-minor change applied ( you cant swipe for red alert if the ship is already on red alert)

[Zonespace27]

Follow cthulhu's reviews please

[Diegoflores31]

github web moment 💀

[fira]

looks good codewise

[github-actions]

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

[fira]

Testing take 2 to confirm this effectively works as intended

[ihatethisengine]

Hello, diego!

I think in general this is a great feature, but it's absolutely unusable in the current state. There is no working feedback whatsoever. You never know why you fail. Is it a second lieutenant who failed to swipe the ID in time? Did you not fulfill some requirements? Did it just bugged out? Please add messages on fail describing what go wrong. I see there are messages you added but they don't work in-game. Probably you should rework the messages the way it shows visible message for everyone around the swiping thing, not to usr which is probably null.

Also, as far as I am aware, you can swipe the card for ERT only after the crash, which is extremely nonviable. Let people call ERT just after hijack, you can just forbid it from landing before crash or add a timer.

Sincerely, your good friend.

[Diegoflores31]

There is currently a bug that some times your swipes wont register . I am almost 100% its because of table code . I will probably add some additional features today to make it more intuitive

[Drulikar]

I think the issue with this is mostly just confusion/feedback to users.

Consider adding a sound/balloon_alert whenever the keycard_auth activates/times out (I believe that occurs here: https://github.com/cmss13-devs/cmss13/blob/master/code/modules/security_levels/keycard_authentication.dm#L116-L132

Also consider adding a message if a different user tries to authorize the same keycard_auth - or allow the same machine to both initiate and confirm a request if the triggerer/confirmer is a different user.

[github-actions]

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself