Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Working Joe Voicelines #4501

Merged
merged 13 commits into from
Sep 28, 2023

Conversation

Ben10083
Copy link
Contributor

@Ben10083 Ben10083 commented Sep 25, 2023

About the pull request

Additional Working Joe voicelines, reorganization of existing voicelines.

Explain why it's good for the game

RP. In all seriousness, with tireless efforts of many individuals to find these voicelines, organize them, and determine what to add, this expansion should improve the Working Joe experience.
 

Testing Photographs and Procedure

image

Changelog

🆑
soundadd: Multiple new Working Joe voicelines added
/:cl:

@github-actions github-actions bot added the Sound Blast 5 minutes of bass boosted music to our players label Sep 25, 2023
@BroseidonMOO BroseidonMOO added the Testmerge Candidate we'll test this while you're asleep and the server has 10 players label Sep 25, 2023
@Biolock1 Biolock1 mentioned this pull request Sep 25, 2023
3 tasks
@Biolock1 Biolock1 mentioned this pull request Sep 25, 2023
3 tasks
Copy link
Member

@morrowwolf morrowwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these oggs are normalized to -8db correct?

@morrowwolf morrowwolf marked this pull request as draft September 26, 2023 16:06
@CGosling
Copy link
Contributor

QoL change which is through the roof, love it.

@Ben10083 Ben10083 marked this pull request as ready for review September 28, 2023 00:50
@morrowwolf morrowwolf added this pull request to the merge queue Sep 28, 2023
Merged via the queue into cmss13-devs:master with commit 8cad63f Sep 28, 2023
25 checks passed
cm13-github added a commit that referenced this pull request Sep 28, 2023
@Ben10083 Ben10083 deleted the Working-Joe-Emotes branch September 29, 2023 03:34
github-merge-queue bot pushed a commit that referenced this pull request Oct 1, 2023
# About the pull request

Fix a method forgotten to be renamed in #4501

# Explain why it's good for the game

 Bugs bad

# Changelog
:cl:
fix: fixed a Working Joe voiceline from not working
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sound Blast 5 minutes of bass boosted music to our players Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants