-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional Working Joe Voicelines #4501
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Sound
Blast 5 minutes of bass boosted music to our players
label
Sep 25, 2023
BroseidonMOO
added
the
Testmerge Candidate
we'll test this while you're asleep and the server has 10 players
label
Sep 25, 2023
BroseidonMOO
approved these changes
Sep 25, 2023
morrowwolf
reviewed
Sep 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these oggs are normalized to -8db correct?
QoL change which is through the roof, love it. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 1, 2023
# About the pull request Fix a method forgotten to be renamed in #4501 # Explain why it's good for the game Bugs bad # Changelog :cl: fix: fixed a Working Joe voiceline from not working /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Sound
Blast 5 minutes of bass boosted music to our players
Testmerge Candidate
we'll test this while you're asleep and the server has 10 players
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Additional Working Joe voicelines, reorganization of existing voicelines.
Explain why it's good for the game
RP. In all seriousness, with tireless efforts of many individuals to find these voicelines, organize them, and determine what to add, this expansion should improve the Working Joe experience.
Testing Photographs and Procedure
Changelog
🆑
soundadd: Multiple new Working Joe voicelines added
/:cl: