makes LZ detector work while landed #4516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Balance
morrowwolf
suggested changes
Sep 28, 2023
This was referenced Sep 29, 2023
This comment was marked as off-topic.
This comment was marked as off-topic.
morrowwolf
suggested changes
Oct 2, 2023
There was a problem hiding this comment.
update_equipment() is called more than just taking it on and off so when you're picking it up and such it will runtime as there's no linked_cam_console at line 529 after it goes into the else given ship_base is not set.
Secondly, I'd recommend early returns instead of else here so add a return at the end of the if(ship_base) block and then remove the else. (if you keep the current structure while fixing it)
ghost
reviewed
Oct 5, 2023
Comment on lines
522
to
544
| linked_cam_console.network.Add(CAMERA_NET_LANDING_ZONES) //only accessible while in the air. | ||
| for(var/datum/weakref/ref in linked_cam_console.concurrent_users) | ||
| var/mob/user = ref.resolve() | ||
| if(user) | ||
| linked_cam_console.update_static_data(user) | ||
| icon_state = "[initial(icon_state)]_installed" | ||
| else | ||
| linked_cam_console.network.Remove(CAMERA_NET_LANDING_ZONES) | ||
| for(var/datum/weakref/ref in linked_cam_console.concurrent_users) | ||
| var/mob/user = ref.resolve() | ||
| if(user) | ||
| linked_cam_console.update_static_data(user) | ||
| linked_cam_console = null | ||
| icon_state = initial(icon_state) | ||
|
|
||
|
|
||
| /obj/structure/dropship_equipment/electronics/landing_zone_detector/Destroy() | ||
| if(linked_cam_console) | ||
| linked_cam_console.network.Remove(CAMERA_NET_LANDING_ZONES) | ||
| for(var/datum/weakref/ref in linked_cam_console.concurrent_users) | ||
| var/mob/user = ref.resolve() | ||
| if(user) | ||
| linked_cam_console.update_static_data(user) |
There was a problem hiding this comment.
you got a lot of repeating code here, you can stuff a good portion of that into like a proc if ya really wanted.
/obj/structure/dropship_equipment/electronics/landing_zone_detector/update_cam_access(cam_access)
if(cam_access)
linked_cam_console.network.Add(CAMERA_NET_LANDING_ZONES)
else
linked_cam_console.network.Remove(CAMERA_NET_LANDING_ZONES)
for(var/datum/weakref/ref in linked_cam_console.concurrent_users)
var/mob/user = ref.resolve()
if(user)
linked_cam_console.update_static_data(user)
call it like update_cam_access(insert boolean here)
Or something similar
cm13-github
added
the
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Zonespace27
added
the
Balance Approved
cuberound
force-pushed
the
LZ-detector-change
branch
from
d9cc1e3
to
d9250db
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 2, 2023
remade some stuff from #4516 to clean up the code, rest is the same. did not get to test it also not shure if I solved the mergeconflict properly if not tell me what is wrong :cl: balance: LZ detector now works even when the DS is stationary /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR makes it so that LZ detector works all the time not only when in air.
Explain why it's good for the game
The fact that LZ detector worked only when in air made it near useless, when you are already headed for the LZ what good is it to see it overrun and how is seeing xeno in FOB after you leave it any good. This turns LZ detector into a tool for transport pilot to better evaluate the situation in FOB before taking off from it or heading to it.
Changelog
🆑
balance: LZ detector now works even when the DS is stationary
/:cl: