Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QOL] You can acid things on surfaces #4542

Closed
wants to merge 1 commit into from

Conversation

TeDGamer
Copy link
Contributor

@TeDGamer TeDGamer commented Sep 28, 2023

About the pull request

Allows aciding of items again on surfaces.

Currently, it says you're too far even if you're adjacent to the item and surface the item is on.

Starts the progress to acid but then says you're too far away. This fixes that.

Explain why it's good for the game

I remember being able to acid items on tables a while back.

Would alt click and then select the items to acid.

Without this, you need to destroy the surface first before aciding the items which is fine but annoying.

I don't think this would change things too much destroying things on the tables without needing to touch the table. Just a minor QOL / fix from what it used to be like.

Changelog

🆑
qol: You can acid objects on surfaces again
/:cl:

@TeDGamer TeDGamer changed the title You can acid things on surfaces with alt click again [QOL] You can acid things on surfaces Sep 28, 2023
@github-actions github-actions bot added the Quality of Life Make the game harder to play label Sep 28, 2023
Copy link
Member

@fira fira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll probably want to also apply that to /mob/living/carbon/xenomorph/runner/corrosive_acid (or be the hero that fixes the fact it's doubled up)

@TeDGamer
Copy link
Contributor Author

You'll probably want to also apply that to /mob/living/carbon/xenomorph/runner/corrosive_acid (or be the hero that fixes the fact it's doubled up)

Damn, didn't realize. I'll take a look.

@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Oct 19, 2023
@github-actions github-actions bot closed this Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quality of Life Make the game harder to play Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants