Refactor gun cabinet code adding subtype for all the secure guncabinet/safes #4574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 2, 2023 12:31
more power to the coder
used around the ship.
github-actions
bot
added
Mapping
added 2 commits
October 2, 2023 13:23
dumb meeeeeeeeeeeeeeeee
added 2 commits
October 3, 2023 14:14
make a subtype for the special coin in CO safe.
Huffie56
changed the title
added 8 commits
October 3, 2023 16:49
identify without opening
|
cutting kitchen stuff for another PR.... |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
harryob
approved these changes
Oct 31, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
cm13-github
added a commit
that referenced
this pull request
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
going to add some subtype for other closets...
chem safes execution....
Explain why it's good for the game
no more mapping change to change content...
meaning less conflict in the future if we want to change themalso it's more clean
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
refactor: Refactor gun cabinet code adding subtype for all the secure guncabinet.
refactor: Refactor safe code adding subtype for cl and co safes also add a subtype for armory honor guard closet .
/:cl: