Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates dropship ammo names to be more "accurate" #4579

Merged
merged 9 commits into from
Oct 7, 2023

Conversation

blackdragonTOW
Copy link
Contributor

@blackdragonTOW blackdragonTOW commented Oct 3, 2023

About the pull request

Updating the names of the ammo used on the dropship to give Air weapons more consistent naming conventions as well as change a couple minor issues with the names of our ordinance:

AIM-224/B 'Widowmaker' is now AIM-224B 'Widowmaker' - No slash needed when adding a modification letter
AGM-84 'Harpoon' is now AGM-184 'Harpoon II' - The AGM-84 'Harpoon' is the actual 100% real deal made in 1977 anti-ship missile still in use today... forgive me but I doubt the USCM is going to continue using the venerable 205 year old weapon.
XN-99 'Napalm' is now AGM-99 'Napalm' - changing to the correct designation type
mini rocket stack is now AGR-59 'Mini-Mike' - this ordinance did not have a designation, gave it one while maintaining the intuitive name as well as giving it the appropriate rocket designation. Also now has a description.
incendiary mini rocket stack is now AGR-59-I 'Mini-Mike' - as above, except with an incendiary tag. Also now has a description.

Explain why it's good for the game

Cool naming conventions make the game more immersive, especially when they're consistent.

Testing Photographs and Procedure

Changelog

🆑
spellcheck: Altered inconsistent dropship ammo names
/:cl:

@github-actions github-actions bot added the Grammar and Formatting Fixes the codebase's tpyos and grammatical's errors label Oct 3, 2023
typos are cringe
@blackdragonTOW
Copy link
Contributor Author

I never make typos. Never.

@fira
Copy link
Member

fira commented Oct 3, 2023

Wouldn't Napalm be a GBU ?

I always referred the minipods as "Vipers" becuase that's how it's called on the wiki
---> https://cm-ss13.com/wiki/USS_Almayer#Armament_2

@blackdragonTOW
Copy link
Contributor Author

blackdragonTOW commented Oct 3, 2023

Wouldn't Napalm be a GBU ?

I always referred the minipods as "Vipers" becuase that's how it's called on the wiki ---> https://cm-ss13.com/wiki/USS_Almayer#Armament_2

The "Napalm" has a description listing it as a missile, so it wouldn't be a Guided Bomb Unit. So AGM is the best closest option.

The mini-rocket change is specifically to the ammo that goes into the pod, rather than the pod itself. The name "mini-mike" is specifically to help ease the transition from "minirocket ammo" to an actual name. However if people feel strongly about it having a different name I do not mind (the AGR designation is the correct one for the ordinance type, however.)

@fira
Copy link
Member

fira commented Oct 5, 2023

Makes sense. Should probably take the occasion to update the weapons at same time then

@blackdragonTOW
Copy link
Contributor Author

blackdragonTOW commented Oct 5, 2023

Updates on two:
"multi-purpose area denial sentry" becomes "A/C-49-P Air Deployable Sentry" meaning: Aero Combination ground/airborne, (49) Gunnery based Protection.

and

"laser battery" becomes "BTU-17/LW Hi-Cap Laser Battery" meaning: BaTtery Unit design 17 to be used with Laser Weapons.

Again, while having fun designations are cool, I've done my best to keep 'plain English' names inside for ease of use. Will work on weapons later today.

@blackdragonTOW
Copy link
Contributor Author

Sweep complete, designations added, names changed to make what they do a little more clear to fresh POs. Additionally each weapon and ammo should have an altered description that explains what ammo/weapon it goes with, to help in the learning process.

@Zonespace27 Zonespace27 added this pull request to the merge queue Oct 7, 2023
Merged via the queue into cmss13-devs:master with commit a17b58a Oct 7, 2023
25 checks passed
cm13-github added a commit that referenced this pull request Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Grammar and Formatting Fixes the codebase's tpyos and grammatical's errors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants