Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dead Spider Sprite Fix #4585

Merged
merged 4 commits into from
Oct 5, 2023
Merged

Dead Spider Sprite Fix #4585

merged 4 commits into from
Oct 5, 2023

Conversation

blackdragonTOW
Copy link
Contributor

@blackdragonTOW blackdragonTOW commented Oct 4, 2023 •
edited by github-actions bot
Loading

About the pull request

Dead spiders had white pixels where there should be transparent pixels.

Explain why it's good for the game

Sprite bug fix gud

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
fix: fixed spider dead sprite to not have white space (is transparent instead)
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Fix Fix one bug, make ten more labels Oct 4, 2023
sleepynecrons
sleepynecrons approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@sleepynecrons sleepynecrons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good fix

@sleepynecrons sleepynecrons added the Sprites Approved confirmed no stray pixels label Oct 4, 2023
sleepynecrons
sleepynecrons suggested changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@sleepynecrons sleepynecrons left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually i was a little too hasty on approving, sorry for that. after checking the other spiders they also have stray white pixels. please fix those along with the dead hunter

@sleepynecrons sleepynecrons removed the Sprites Approved confirmed no stray pixels label Oct 4, 2023
@blackdragonTOW
Copy link
Contributor Author

I come in here and fix these sprites and THIS IS THE THANKS I GET? Do you have ANY idea how long it took me to remove those pixels??? At LEAST ten seconds. Do you think anyone has ten seconds just LAYING around? Do you think -I- have ten seconds laying around? ...oh, I do actually. Yeah that's valid. New spiders up.

blackdragonTOW
blackdragonTOW commented Oct 4, 2023
View reviewed changes
Copy link
Contributor Author

@blackdragonTOW blackdragonTOW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New spooders up!

sleepynecrons
sleepynecrons approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@sleepynecrons sleepynecrons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for cleaning up the other two. approved [again]

@sleepynecrons sleepynecrons added the Sprites Approved confirmed no stray pixels label Oct 4, 2023
@sleepynecrons sleepynecrons added this pull request to the merge queue Oct 5, 2023
Merged via the queue into cmss13-devs:master with commit 68a487a Oct 5, 2023
25 checks passed
cm13-github added a commit that referenced this pull request Oct 5, 2023
@cm13-github
Automatic changelog for PR #4585 [ci skip]
6f16651
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleepynecrons sleepynecrons sleepynecrons approved these changes

Assignees
No one assigned
Labels
Fix Fix one bug, make ten more Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blackdragonTOW @sleepynecrons