-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added a file to handle the fridges in kitchen on almayer and added a bunch of food boxes. #4586
Conversation
create subtype for kitchen alamyer
one is for kitchen proper.
if you could replace REQ crate to use these boxes it would be neat |
i intend to make a vendor that sell those boxes to the cook directly using snowflake point pool... |
it still vaible to grow them.
and added a surplus ingredient crate in ASRS
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All your for loops differ from standard advice.. I stopped adding comments when I realised how many there were in this.
https://github.com/cmss13-devs/cmss13/blob/master/.github/guides/STANDARDS.md#in-to-for-loops
it's faster.
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
code/game/objects/structures/crates_lockers/closets/secure/kitchen.dm
Outdated
Show resolved
Hide resolved
code/game/objects/structures/crates_lockers/closets/secure/kitchen.dm
Outdated
Show resolved
Hide resolved
code/game/objects/structures/crates_lockers/closets/secure/kitchen.dm
Outdated
Show resolved
Hide resolved
code/game/objects/structures/crates_lockers/closets/secure/kitchen.dm
Outdated
Show resolved
Hide resolved
code/game/objects/structures/crates_lockers/closets/secure/kitchen.dm
Outdated
Show resolved
Hide resolved
code/game/objects/structures/crates_lockers/closets/secure/kitchen.dm
Outdated
Show resolved
Hide resolved
code/game/objects/structures/crates_lockers/closets/secure/kitchen.dm
Outdated
Show resolved
Hide resolved
change to the correct for(var/i in 1 to 7) type should be fine |
About the pull request
i wanted to make it more clear code wise and separating the fridge used on colony and other places from main kitchen.
the food boxes are there to help make stock version having less item into them and make it cleaner.
made two version of each fridge on that hold less for the front kitchen and one for the stock in the back room that hold way more.
remove a bunch of food crate that are duplicate with the vendor.
add a vendor that sell boxes of ingredients.
Explain why it's good for the game
better organization for kitchen and separation from other fridge allow to not add item on top of fridge if you want to give him more...
cook will now be able to buy directly will hydroponic will stay viable and they are still able to order or receive supply from req..
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑
add: Added a lot's of food boxes for that hold the basic ingredients for cooking.
add: Added a file to handle the fridges in almayer kitchen.
add: Added a vendor in the kitchen that sell boxes of ingredients.
add: Added a a food crate called surplus boxes ingredient containing random boxes of ingredients.
add: Added a version of this crate that will be freely given via the ASR system.
/:cl: