Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tgui research desktop fix #4592

Merged
merged 2 commits into from
Oct 7, 2023

Conversation

kiVts
Copy link
Contributor

@kiVts kiVts commented Oct 5, 2023

About the pull request

3 out of 4

Have you ever noticed that when you simulate something new, lets say you called it "gamer juice" and instead, in computer lab it always has "for" instead of the actual name that you created? this is because "Analysis of X" Has two words before the name of the chemical while "Simulation results for X" has 3

TGUI splits it the same way despite having different number of words, thus, "Simulation results for X" - this is where For comes from.

I had two ways to do it, either remove third word, or try to fix it in tgui, this however, still doesnt include the spaces you can put in the name.

(tgui is weiiirdd, if I did something funny which I dont get, sorry)

Explain why it's good for the game

Always annoying to look for correct chemical you did in like ~8 "for"

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 kiVts
fix: Research computer no longer shows "for" for every simulation result.
/:cl:

@github-actions github-actions bot added UI deletes nanoui/html Fix Fix one bug, make ten more labels Oct 5, 2023
@fira
Copy link
Member

fira commented Oct 6, 2023

can't chems be multi word named anyway?

@kiVts
Copy link
Contributor Author

kiVts commented Oct 6, 2023

can't chems be multi word named anyway?

yes, but at least its not always "for" now
e.g. "Orange Juice" Will only have "Orange" in the research console, but the name is too long to put its entire name anyway

Copy link
Contributor

@Zonespace27 Zonespace27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit gross but it'll work for now

@Zonespace27 Zonespace27 added this pull request to the merge queue Oct 7, 2023
Merged via the queue into cmss13-devs:master with commit 439762c Oct 7, 2023
25 checks passed
cm13-github added a commit that referenced this pull request Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more UI deletes nanoui/html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants